Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to send a radar ping with lua #15359

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
4 participants
@MustaphaTR
Copy link
Member

MustaphaTR commented Jul 18, 2018

I noticed we don't have a way to show radar pings with Lua when i wanted to ping for reinforcements in a map i made.

Tescase adds Radar Pings to Harkonnen 5 on ConYard when player reinforcements come.

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jul 18, 2018

True, we only used beacons before.

Travis:

OpenRA.Mods.Common/Scripting/Global/RadarGlobal.cs:L12: [SA1507] The code must not contain multiple blank lines in a row.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:lua-radar-ping branch from 179455a to 07b5135 Jul 18, 2018

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@pchote pchote force-pushed the MustaphaTR:lua-radar-ping branch from 07b5135 to 741efd6 Jul 25, 2018

@pchote

pchote approved these changes Jul 25, 2018

Copy link
Member

pchote left a comment

LGTM. I have pushed over your branch to remove the testcase.

@pchote pchote merged commit 9c61217 into OpenRA:bleed Jul 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:lua-radar-ping branch Jul 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.