Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Explodes->DeathTypes when Threshold is above 0. #15382

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
3 participants
@GraionDilach
Copy link
Contributor

GraionDilach commented Jul 24, 2018

Fixes #15376.

@@ -134,6 +134,9 @@ void INotifyDamage.Damaged(Actor self, AttackInfo e)
if (Info.DamageThreshold == 0)
return;

if (Info.DeathTypes.Count > 0 && !e.Damage.DamageTypes.Overlaps(Info.DeathTypes))

This comment has been minimized.

@chrisforbes

chrisforbes Jul 26, 2018

Member

More HashSet<string> insanity, but looks correct.

This comment has been minimized.

@GraionDilach

GraionDilach Jul 26, 2018

Author Contributor

Come to think of it, aiming Damage/DeathTypers to convert to BitSet in Next+1 sounds like a worthwhile aim.

@pchote

pchote approved these changes Jul 26, 2018

@pchote pchote merged commit e9c3927 into OpenRA:bleed Jul 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GraionDilach GraionDilach deleted the GraionDilach:explodes-threshold-damagetypes branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.