Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper ProductionItem costs calculation. #15387

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
4 participants
@IceReaper
Copy link
Contributor

IceReaper commented Jul 26, 2018

The current formula fits for games where units cost more than their buildtime. If however a mod uses lower prices, the formula shows a problem. Example: unit costs 50 but has a build time of 100. The unit will be half build when the game starts to consume money. Expected behavior however is that every second tick, 1 money is consumed.

@FrameLimiter

This comment has been minimized.

Copy link
Contributor

FrameLimiter commented Jul 26, 2018

Closes #11075

@pchote

pchote approved these changes Jul 26, 2018

Copy link
Member

pchote left a comment

LGTM

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jul 26, 2018

#11075 provides a convenient test case for this. Lets try and get this in for the playtest.

@pchote pchote added this to the Next release milestone Jul 26, 2018

@pchote pchote added the PR: Needs +2 label Jul 26, 2018

@MustaphaTR MustaphaTR merged commit a57cfc7 into OpenRA:bleed Jul 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MustaphaTR

This comment has been minimized.

Copy link
Member

MustaphaTR commented Jul 26, 2018

@IceReaper IceReaper deleted the IceReaper:production_cost branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.