New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant Mission 1 #15396

Merged
merged 1 commit into from Dec 30, 2018

Conversation

Projects
None yet
7 participants
@Cheesy0314
Copy link

Cheesy0314 commented Jul 27, 2018

Created new PR with just ant mission 1, last request had multiple missions in it.

Pulled map.bin and map.yaml from #15213, map.png from cnc-wiki and rescaled.

This is an attempt to complete part of #4989

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch from 6b23ddd to 1adae14 Jul 27, 2018

@Cheesy0314 Cheesy0314 referenced this pull request Jul 27, 2018

Open

Ant Mission 2 #15397

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch from 1adae14 to aad7304 Jul 27, 2018

@Smittytron
Copy link
Contributor

Smittytron left a comment

This looks promising! Here are some initial thoughts after playing it through.

  • Was the timer really 30 full minutes? That's a long time, I bet the clock ticked faster.

  • Because the base buildings are allied to the player, their health bars will show to anyone who has bars set to show on damage or always show.

  • The player starts with 1500 cash in the original. Also, destroying the oil derrick yielded a money crate.

  • Snipers need to be disabled.

  • The ant colors will need tweaking. The scouts were black, fire ants were orange, and warriors were red.

  • Do we want the openra flamethrower or the fireballs for the fire ants? I'm leaning fireballs.

  • Change the commit title to something like 'Add Ant Mission 1'

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch from aad7304 to f7f666c Jul 28, 2018

@Cheesy0314

This comment has been minimized.

Copy link

Cheesy0314 commented Jul 28, 2018

Ok, so far:

  • Disabled Snipers
  • Set starting funds to 1500
  • Changed building owner allies so health bar wouldn't display
  • Changed commit title

TODO:

  • Attempt to tweak colors of ants
  • Change fireball animation
  • Possibly decrease time (Although original was 30 mins)
@johnweven

This comment has been minimized.

Copy link

johnweven commented Jul 28, 2018

I am very glad to hear that someone was willing to do the scripts! Yes, it originally was 30 minutes from the original game. We could keep the 30 minutes there if you had the dropdown difficulty set to very easy or easy, and the timer can vary for each difficulty.

FireAnts = {"fireant"}
WarriorAnts = {"ant"}
AlliedForces = {"2tnk","2tnk","mcv"}
ChooperTeam = {"e1r1","e1r1","e2","e2","e1r1"}

This comment has been minimized.

@johnweven

johnweven Jul 28, 2018

Was it supposed to say Chopper? Or was it intended to say Chooper?

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch 3 times, most recently from f5e91cb to c77b2a2 Jul 28, 2018

@Cheesy0314

This comment has been minimized.

Copy link

Cheesy0314 commented Jul 28, 2018

No haha meant chopper, hit the "o" twice instead of "p", good catch!

I am very glad to hear that someone was willing to do the scripts!

@johnweven Yes I saw your branch and figured I'd take a crack at it! You did the part I didn't want to do so it was easy enough after that. Plus, had a few slow days at work and this made the day pass by faster.

So update:
Fixed "Chooper" spelling mistake

Didn't Fix:
Changed fire animation, needs more work
Couldn't fix color, not sure why player color isn't changing

TODO:
Try to use old fireball animation
Get ant color(s) to change
Finalize last changes

Mobile:
Speed: 80
Armament:
Weapon: Flamer

This comment has been minimized.

@Smittytron

Smittytron Jul 28, 2018

Contributor

I'd just use FireballLauncher as the weapon.

Armament:
Weapon: Flamer
Health:
HP: 70000

This comment has been minimized.

@Smittytron

Smittytron Jul 28, 2018

Contributor

Style nit: Use empty lines between each rule

HP: 80000
MEDI:
Valued:
Cost: 500

This comment has been minimized.

@Smittytron

Smittytron Jul 28, 2018

Contributor

I'd take this out. The default medic price shouldn't hurt anything.

Prerequisites: ~disabled
MNLY:
Buildable:
Prerequisites: ~techlevel.low

This comment has been minimized.

@Smittytron

Smittytron Jul 28, 2018

Contributor

This override shouldn't be necessary.

Prerequisites: ~disabled
SNIPER:
Buildable:
Prerequisites: ~disabled

This comment has been minimized.

@Smittytron

Smittytron Jul 28, 2018

Contributor

Snipers are disabled by default. Removing the custom override should have been enough to take it out.

Scripts: ant-01.lua
MissionData:
BackgroundVideo: antintro.vqa
Briefing: We've lost contact with one of our outposts. Before it went off-line, we recieved a brief communique about giant ants. We're unsure what to make of this report, so we want you to investigate. \n\nScout the area, bring the outpost back on-line, and report your findings. If there is a threat, reinforcements will be sent in to help you. \n\nKeep the base functional and radio contact open -- we don't want to lose the outpost again.

This comment has been minimized.

@Smittytron

Smittytron Jul 28, 2018

Contributor

Move player and world to the top. This is how the other missions are sorted.

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch 3 times, most recently from 1d0f3c9 to 6fa550e Jul 30, 2018

@Cheesy0314

This comment has been minimized.

Copy link

Cheesy0314 commented Jul 30, 2018

Made requested changes, removed unused weapons.yaml

Fixed bug in lua script

InsertionHelicopterType = "tran"
InsertionPath = { waypoint12.Location, waypoint0.Location }
baseDiscovered = false
AlliedBase = {Actor99, Actor100, Actor101, Actor102, Actor103, Actor104, Actor105, Actor106, Actor107, Actor129}

This comment has been minimized.

@MustaphaTR

MustaphaTR Jul 30, 2018

Member

Space after opening, before closing brackets and after comma here and other unit definitions please.

Also would be nice if you named the buildings.

This comment has been minimized.

@Cheesy0314

Cheesy0314 Jul 30, 2018

Yeah I meant to name them and never did, good call

TimerTicks = DateTime.Minutes(30)
ticks = TimerTicks

WorldLoaded = function()

This comment has been minimized.

@MustaphaTR

MustaphaTR Jul 30, 2018

Member

World Loaded should go to end and init objectives above it.

AntSendFunc(direction, amount, "ant")
end


This comment has been minimized.

@MustaphaTR

MustaphaTR Jul 30, 2018

Member

Double new line.

@Smittytron

This comment has been minimized.

Copy link
Contributor

Smittytron commented Jul 30, 2018

I was able to override the colors by removing the campaign-palettes, but I don't know if that's the right way to go about it. Would @abcdefg30 or @MustaphaTR know if that's an acceptable workaround?

@MustaphaTR

This comment has been minimized.

Copy link
Member

MustaphaTR commented Jul 30, 2018

What is wrong with the colors again? I think they are correct.

Also some stuff i noticed. You can select and make the chinook stay. Preferably it should be unselectable so you can't mess with it. And ants have Enemy prefix behind them, which i don't think they should. You should make them use normal names and not generic names and remove Giant from normal name imo.

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch 2 times, most recently from d483159 to 8b0b8fc Jul 30, 2018

@Cheesy0314

This comment has been minimized.

Copy link

Cheesy0314 commented Jul 30, 2018

Ok, update with better coding practices!

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch 5 times, most recently from a2eebc7 to 2508825 Jul 30, 2018

This was referenced Sep 2, 2018

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch 2 times, most recently from a8dc6f8 to 633c636 Sep 4, 2018

@Cheesy0314

This comment has been minimized.

Copy link

Cheesy0314 commented Sep 10, 2018

OK set the ant time logic for warrior ants, also delayed fire ants a minute or so

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 24, 2018

What is the review status here @abcdefg30, @Smittytron, @reaperrr?

@Cheesy0314 Cheesy0314 force-pushed the Cheesy0314:ant-mission-1 branch from 633c636 to 6ffdeda Oct 24, 2018

@Cheesy0314

This comment has been minimized.

Copy link

Cheesy0314 commented Oct 24, 2018

Fixed merge conflict

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 25, 2018

There are a bunch of style issues here. @Cheesy0314 would you mind if I just fixed them and added my fixes to your commit (this will probably take less time than explaining each of them)? I can also file a PR with my suggestions towards your fork if you want that.

@Cheesy0314

This comment has been minimized.

Copy link

Cheesy0314 commented Oct 25, 2018

@abcdefg30 yeah you are more than welcome to do what you need to, whatever is easier I don't mind.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 19, 2018

Any progress here @abcdefg30?

@pchote pchote referenced this pull request Nov 30, 2018

Closed

Added map sca01ea #15869

@reaperrr reaperrr force-pushed the Cheesy0314:ant-mission-1 branch from 6ffdeda to 5f3a0cc Dec 26, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 26, 2018

Sorry for the long silence on this.

I've taken the liberty to push some fixes and difficulty adjustments to the branch, to save some time and hopefully get this merged quickly now.

Fixes:

  • Fixed that the switch from occasional scouts to only warriors would only work on normal, and not hard (the if and elsif previously both checked for DifficultySetting == "normal").
  • Removed a few redundant empty lines from the lua scripts.

Difficulty adjustments:

  1. Reduced max ants from
  • 5 to 3 on easy, and
  • 6 to 5 on normal.
    Note: This doesn't reduce difficulty as much as it seems, because a) fire ants remain untouched and b) due to the random factors, it only reduces the worst-case size of ant attacks towards the end.
  1. Switch from random scouts to "only fire- and warrior ants" now happens 4 minutes later on normal (after 12 instead of after 8 mins), but 2 minutes earlier on hard (after 6 instead of 8 minutes).

👍 from me, @abcdefg30 if you still plan to adress those style issues it would be great if you could do that soon (or comment if you'd rather file a follow-up later).

@reaperrr reaperrr added this to the Next Release milestone Dec 29, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 29, 2018

We should try to get this into the playtest.

@Smittytron

This comment has been minimized.

Copy link
Contributor

Smittytron commented Dec 30, 2018

The spawn points for the ants should be at the edges of the map.

@reaperrr reaperrr force-pushed the Cheesy0314:ant-mission-1 branch from 5f3a0cc to 1ca66fa Dec 30, 2018

@reaperrr reaperrr merged commit f5d12bf into OpenRA:bleed Dec 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 30, 2018

changelog

To not further delay this, I fixed the spawn positions myself as well. We still have time to polish this some more until release if necessary, but for now it was important to get this into the playtest.

Thanks for the work @Cheesy0314!

@obrakmann obrakmann referenced this pull request Jan 1, 2019

Open

Add Red Alert campaign #4989

6 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment