New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change menu cancel buttons to back #15410

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
3 participants
@Smittytron
Copy link
Contributor

Smittytron commented Jul 29, 2018

Closes #15398

The only change I'm unsure of is the save map button. It can be argued that save map is a prompt instead of part of the menu navigation, and thus makes more sense as 'cancel'. We're splitting hairs either way so I went ahead and pushed it as requested by @FrameLimiter

If anyone has the same hang-up I can take the save map change out.

@@ -170,7 +170,7 @@ Container@SAVE_MAP_PANEL:
Y: PARENT_BOTTOM - 35
Width: 140
Height: 35
Text: Cancel

This comment has been minimized.

@chrisforbes

chrisforbes Jul 29, 2018

Member

Nak to this one.

@chrisforbes
Copy link
Member

chrisforbes left a comment

Actually, no, nak to this whole thing.

Changed my mind about this.

@chrisforbes
Copy link
Member

chrisforbes left a comment

If you change the save map panel button back, 👍

@chrisforbes chrisforbes requested a review from pchote Jul 29, 2018

@Smittytron Smittytron force-pushed the Smittytron:cancel-to-back branch from ffcdbb1 to 4a9280c Jul 30, 2018

@Smittytron

This comment has been minimized.

Copy link
Contributor

Smittytron commented Jul 30, 2018

Updated

@Smittytron Smittytron force-pushed the Smittytron:cancel-to-back branch from 4a9280c to 67a339f Aug 19, 2018

@pchote

pchote approved these changes Sep 28, 2018

@pchote pchote merged commit 2bb2cd5 into OpenRA:bleed Sep 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Smittytron Smittytron deleted the Smittytron:cancel-to-back branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment