New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bitsets #15413

Merged
merged 2 commits into from Aug 19, 2018

Conversation

Projects
None yet
6 participants
@chrisforbes
Copy link
Member

chrisforbes commented Jul 29, 2018

More HashSet -> BitSet conversions

@chrisforbes chrisforbes requested review from pchote and reaperrr Jul 29, 2018

@chrisforbes chrisforbes force-pushed the chrisforbes:misc-bitsets branch from 79717ce to 5672fdc Jul 29, 2018

@chrisforbes chrisforbes force-pushed the chrisforbes:misc-bitsets branch from 5672fdc to d21a054 Jul 29, 2018

@chrisforbes

This comment has been minimized.

Copy link
Member

chrisforbes commented Jul 29, 2018

Bunch of churn here; apparently I like to drop random semicolons after class definitions...

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@pchote pchote added the PR: Needs +2 label Jul 29, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jul 29, 2018

Is it just me, or does this break cloak detection in the RA mod? (test with phase transports vs radar domes)

@Smittytron

This comment has been minimized.

Copy link
Contributor

Smittytron commented Jul 29, 2018

Is it just me, or does this break cloak detection in the RA mod? (test with phase transports vs radar domes)

Yep, broke it for me.

@chrisforbes

This comment has been minimized.

Copy link
Member

chrisforbes commented Jul 29, 2018

Fixed.

@chrisforbes chrisforbes added this to the Next + 1 milestone Jul 29, 2018

@teinarss

This comment has been minimized.

Copy link
Contributor

teinarss commented Aug 6, 2018

The stealth detection works now in TD.

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Aug 19, 2018

Nvm me today, I'm blind.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍 again

@reaperrr reaperrr merged commit 67d9ad6 into OpenRA:bleed Aug 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Aug 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment