Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of Server.ExternalPort #15458

Merged
merged 1 commit into from Aug 4, 2018

Conversation

Projects
None yet
3 participants
@abcdefg30
Copy link
Member

abcdefg30 commented Aug 4, 2018

The ExternalPort setting was removed a while ago.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:ePort branch from 2a6951e to 5d66619 Aug 4, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Aug 4, 2018

IMO we should pick this for the release, too.

@reaperrr reaperrr added this to the Next release milestone Aug 4, 2018

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr merged commit e8068cf into OpenRA:bleed Aug 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Aug 4, 2018

@abcdefg30 abcdefg30 deleted the abcdefg30:ePort branch Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.