New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: Aircrafts land instantly to reload their ammo. #15459

Merged
merged 1 commit into from Aug 4, 2018

Conversation

Projects
None yet
3 participants
@BGluth
Copy link
Contributor

BGluth commented Aug 4, 2018

The Land activity was not taking into account the terrain height when calculating it's landing altitude and was causing non-helicopters to land instantly when above if the landing area was on raised terrain. This should also still allow for landing on units that are in the air (#13701), although I don't think I can test this with the base mods.

  • Fixes #14312.
  • Also tested for obvious issues in TD and RA.
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Aug 4, 2018

Minor style issue:

OpenRA.Mods.Common/Activities/Air/Land.cs:L47: [SP2000] Invalid spacing at the end of the line.

Fixed aircraft in TS landing instantly to reload their ammo
- Updated calculating the landing altitude for the Land activity not taking into account the terrain height.
- Fixes 14312.

@BGluth BGluth force-pushed the BGluth:14312_TS_Aircraft_Landing branch from 3edd85e to 57536e5 Aug 4, 2018

@BGluth

This comment has been minimized.

Copy link
Contributor

BGluth commented Aug 4, 2018

@reaperrr
Fixed.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr merged commit 5c42f55 into OpenRA:bleed Aug 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment