Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ShpTD empty space trimming. #15470

Merged
merged 1 commit into from Aug 4, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Aug 4, 2018

This reverts #15148 and #15375. The regressions aren't worth it for what is now "just" a VRAM saving (#15194 took care of the batch breakage).

Fixes #15462
Fixes #15350 (the previous PR was just a workaround)

This can be restored after someone fixes the broken coordinate handling through the renderer (which would also let us fix #7883).

Revert ShpTD empty space trimming.
This reverts the following commits:
 * 1faae73
 * a7d39fc

@pchote pchote added this to the Next release milestone Aug 4, 2018

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr merged commit 567ab47 into OpenRA:bleed Aug 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Aug 4, 2018

@pchote pchote deleted the pchote:revert-trim-shptd branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.