New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflicts between actor and API names (Radar) #15481

Merged
merged 1 commit into from Aug 10, 2018

Conversation

Projects
None yet
6 participants
@abcdefg30
Member

abcdefg30 commented Aug 5, 2018

Fixes #15449.

#15359 added Radar as part of the API, which conflicted with actor names in the broken missions.

@abcdefg30 abcdefg30 added this to the Next release milestone Aug 5, 2018

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 5, 2018

Member

Ah, well that explains that. Fail.

Member

pchote commented Aug 5, 2018

Ah, well that explains that. Fail.

@@ -342,7 +342,7 @@ Actors:
Tower2: gtwr
Location: 23,21
Owner: GDI
Radar: hq

This comment has been minimized.

@MustaphaTR

MustaphaTR Aug 5, 2018

Member

TD Radar is not a Radar Dome, it is called Communitcaitions Center, CommCenter should do for unit's name.

@MustaphaTR

MustaphaTR Aug 5, 2018

Member

TD Radar is not a Radar Dome, it is called Communitcaitions Center, CommCenter should do for unit's name.

@obrakmann

There's another occurrence in nod06a.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 5, 2018

Member

Fixed.

Member

abcdefg30 commented Aug 5, 2018

Fixed.

@GraionDilach

👍

@obrakmann

👍

@obrakmann obrakmann merged commit 0b53c1f into OpenRA:bleed Aug 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Show comment
Hide comment
@obrakmann
Contributor

obrakmann commented Aug 10, 2018

@abcdefg30 abcdefg30 deleted the abcdefg30:renameRadar branch Aug 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment