New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CNC95Launcher.exe from the IDFiles of the origin cnc install #15488

Merged
merged 3 commits into from Aug 11, 2018

Conversation

Projects
None yet
4 participants
@abcdefg30
Member

abcdefg30 commented Aug 8, 2018

Closes #15445.

@reaperrr reaperrr added this to the Next release milestone Aug 8, 2018

@pchote

Confirmed that this fixes #15445, but the same fix is required for RA and TS before we merge.

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 10, 2018

Member

Updated.

Member

abcdefg30 commented Aug 10, 2018

Updated.

@pchote

Missed the cnc-origin definition at the bottom of RA's origin.yaml. Can you please update this too?

Oops, fixed now

@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30

abcdefg30 Aug 11, 2018

Member

Good catch. Updated.

Member

abcdefg30 commented Aug 11, 2018

Good catch. Updated.

@pchote

pchote approved these changes Aug 11, 2018

@pchote pchote added the PR: Needs +2 label Aug 11, 2018

@reaperrr reaperrr merged commit 94c47fd into OpenRA:bleed Aug 11, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr
Contributor

reaperrr commented Aug 11, 2018

@abcdefg30 abcdefg30 deleted the abcdefg30:cncLauncher branch Aug 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment