New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize dedicated server auth settings and add a glyph to the server list. #15504

Merged
merged 3 commits into from Aug 18, 2018

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Aug 12, 2018

Fixes #15455.

Depends on #15498 and OpenRA/OpenRAMasterServer#57

In addition to the glyph, this replaces/expands the RequireAuthIDs list with separate settings for ID white and black lists, and a default toggle for requiring auth without a specific whitelist.

@pchote pchote added this to the Next release milestone Aug 12, 2018

@pchote pchote changed the title from Masterserver player auth to Generalize dedicated server auth settings and add a glyph to the server list. Aug 12, 2018

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Aug 18, 2018

Member

Rebased and all dependencies have been merged/deployed.

Member

pchote commented Aug 18, 2018

Rebased and all dependencies have been merged/deployed.

@@ -33,6 +34,7 @@ public class GameClient
public GameClient(Session.Client c)
{
Name = c.Name;
Fingerprint = c.Fingerprint;

This comment has been minimized.

@reaperrr

reaperrr Aug 18, 2018

Contributor

Just curious, where is this used? I might have just missed it, but it doesn't look like any of this PR's other changes use this.

@reaperrr

reaperrr Aug 18, 2018

Contributor

Just curious, where is this used? I might have just missed it, but it doesn't look like any of this PR's other changes use this.

This comment has been minimized.

@pchote

pchote Aug 18, 2018

Member

It's not used yet, but at some point in the future we may want to expose registered accounts in the game or web server browsers.

@pchote

pchote Aug 18, 2018

Member

It's not used yet, but at some point in the future we may want to expose registered accounts in the game or web server browsers.

@reaperrr

Looks good to me, and glyph shows up correctly in all mods

@GraionDilach

LGTM.

@reaperrr reaperrr merged commit 8634c00 into OpenRA:bleed Aug 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment