Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix husks not updating targetable positions on teleport #15505

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
4 participants
@reaperrr
Copy link
Contributor

reaperrr commented Aug 12, 2018

Fixes #15329.

@reaperrr reaperrr added this to the Next release milestone Aug 12, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Aug 12, 2018

HuskInfo is missing IPositionableInfo, so this isn't quite enough as-is. Easy fix though thankfully.

Fix husks not updating targetable positions on teleport
This should have checked for IPositionableInfo to begin with.

Husk already implements IPositionable, so implementing *Info as well
makes sense, even if it only serves to exclude it from
ITargetablePositions caching for now.

@reaperrr reaperrr force-pushed the reaperrr:fix-chrono-mech branch from b7b5c75 to e2b6b0c Aug 12, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Aug 12, 2018

Updated (and tested, seems to work).

@pchote

pchote approved these changes Aug 12, 2018

Copy link
Member

pchote left a comment

Code changes look good, but not tested ingame.

@pchote pchote added the PR: Needs +2 label Aug 12, 2018

@matjaeck
Copy link
Contributor

matjaeck left a comment

LGTM

@pchote pchote merged commit c983dda into OpenRA:bleed Aug 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.