Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that TLS 1.2 is enabled for web downloads. #15519

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Aug 15, 2018

Fixes #15518 (hopefully) and prerequisite for fixing OpenRA/OpenRAWeb#372.

@pchote pchote added this to the Next release milestone Aug 15, 2018

@pchote pchote requested a review from MustaphaTR Aug 15, 2018

@pchote pchote referenced this pull request Aug 15, 2018

Open

HTTPS for openra.net #372

@pchote pchote force-pushed the pchote:fix-winten-securityprotocol branch 3 times, most recently from cf7f5d4 to 3d4a4bf Aug 15, 2018

@pchote pchote force-pushed the pchote:fix-winten-securityprotocol branch from 3d4a4bf to 90b77d5 Aug 15, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Aug 16, 2018

@MustaphaTR does this fix it for you?

@MustaphaTR
Copy link
Member

MustaphaTR left a comment

I applied the changes on my engine locally and it downloaded the music properly. 👍

@pchote pchote added the PR: Needs +2 label Aug 16, 2018

@reaperrr
Copy link
Contributor

reaperrr left a comment

Code looks good to me and no regression downloading the cnc quickinstall package

@reaperrr reaperrr merged commit 4a5525d into OpenRA:bleed Aug 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:fix-winten-securityprotocol branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.