New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out of bounds actors from missions #15584

Merged
merged 2 commits into from Sep 25, 2018

Conversation

Projects
None yet
4 participants
@Smittytron
Copy link
Contributor

Smittytron commented Sep 2, 2018

There were several actors left outside the map boundaries when these missions were ported. This removes them, and pulls a few stray waypoints back inside the bounds. There are no trees in d2k, and I did not find any actors outside the bounds there.

@Mailaender

This comment has been minimized.

Copy link
Member

Mailaender commented Sep 2, 2018

Why do you want them removed?

@Smittytron

This comment has been minimized.

Copy link
Contributor

Smittytron commented Sep 2, 2018

The player can't see or interact with these actors. It's effectively junk data.
The waypoints need to be pulled in bounds to work properly. (#14593)

@MunWolf

This comment has been minimized.

Copy link
Contributor

MunWolf commented Sep 3, 2018

Are you sure scripts don't make use of them?

@Smittytron

This comment has been minimized.

Copy link
Contributor

Smittytron commented Sep 3, 2018

Yes, I checked the scripts on every waypoint I removed and on the the units that were outside in Sov03. The used waypoints are the ones I brought back in the boundary.

@Mailaender
Copy link
Member

Mailaender left a comment

Okay then.

@reaperrr reaperrr merged commit 096de8f into OpenRA:bleed Sep 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Sep 25, 2018

@Smittytron Smittytron deleted the Smittytron:remove-outofbounds branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment