New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CrateSpawner sometimes spawning 1 crate too much if Maximum == Minimum #15587

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
2 participants
@reaperrr
Copy link
Contributor

reaperrr commented Sep 4, 2018

In CrateSpawner, if Maximum == Minimum but 'crates' < Maximum, the formula would simply return min + 1 regardless of max being identical to min.
Only adding 1 more crate if Maximum is higher than Minimum fixes that.

Fixes #15586.

Fix spawning 1 crate too much if maximum == minimum
If Maximum == Minimum but 'crates' < Maximum, the formula would simply return min + 1 regardless of max being identical to min.
Only adding 1 more crate if Maximum is higher than Minimum fixes that.

@reaperrr reaperrr changed the title Fix spawning 1 crate too much if maximum == minimum Fix CrateSpawner sometimes spawning 1 crate too much if Maximum == Minimum Sep 4, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Sep 22, 2018

This is a genuine and simple bugfix, so adding to Next+1 milestone.

@reaperrr reaperrr added this to the Next + 1 milestone Sep 22, 2018

@abcdefg30 abcdefg30 merged commit bb7c19a into OpenRA:bleed Sep 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment