New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert RA Grenadier explosion DamageSource. #15594

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@pchote
Member

pchote commented Sep 9, 2018

This is the safest way to fix #15537. Adding a damage type filter to the explosion would require careful auditing and testing of all the potential ways that they could be killed in order to avoid introducing other regressions. This is best left until after the proposed Explodes rework (removing EmptyWeapon and adding InvalidDeathTypes).

@pchote pchote added this to the Next release milestone Sep 9, 2018

@Mailaender Mailaender merged commit 91adc61 into OpenRA:bleed Sep 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender
Member

Mailaender commented Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment