New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the lobby teamchat selector match the in-game selector. #15595

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@pchote
Copy link
Member

pchote commented Sep 9, 2018

Fixes #4516.

@abcdefg30
Copy link
Member

abcdefg30 left a comment

This doesn't work for spectators in the lobby (while they have their own team chat ingame).

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 6, 2018

This is intended to be a simple UI change. I'm not interested in building the spec-chat feature for the lobby, so will close this if you think it is a major blocker.

Up for a follow-up PR then, I guess.

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 7, 2018

19:08:42 (abcdefg30) actually, now I remember what I meant here: https://github.com/OpenRA/OpenRA/pull/15595#issuecomment-427587854
19:08:55 (abcdefg30) you can select "team:" chat as spectator, but it has no effect
19:09:16 (abcdefg30) can't we add a simple check if a player is in a spectator slot and disable the team chat then?
19:09:24 (pchote) ok
19:09:29 (pchote) please leave a comment

@pchote pchote closed this Nov 18, 2018

@pchote pchote deleted the pchote:lobby-teamchat-selector branch Nov 18, 2018

@pchote pchote restored the pchote:lobby-teamchat-selector branch Nov 18, 2018

@pchote pchote reopened this Nov 18, 2018

@pchote pchote force-pushed the pchote:lobby-teamchat-selector branch from 171e39a to e3bf62c Nov 18, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 18, 2018

19:08:55 (abcdefg30) you can select "team:" chat as spectator, but it has no effect

Can you please provide steps to reproduce this? The selector defaults back to "all" and correctly disables itself when switching to spectator in a MP lobby for me.

Also rebased.

@abcdefg30
Copy link
Member

abcdefg30 left a comment

Looks good to me now.

@abcdefg30 abcdefg30 merged commit 6ac7f88 into OpenRA:bleed Nov 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment