New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lint test for audio notifications. #15646

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@pchote
Copy link
Member

pchote commented Sep 25, 2018

This PR adds a lint test for notifications. It improves upon #15033 in a couple of important ways:

  • Accounts for the different notification groups (Sounds, Speech) to avoid false-negatives.
  • Now covers all uses of Sound.PlayNotification (I audited all uses and added many missing references).

Supersedes #15033.
Closes #15024.

Add a lint test for audio notifications.
Only traits are linted - the UI still hardcodes
too many audio references for this to be worthwhile.

@abcdefg30 abcdefg30 merged commit 09d8aaf into OpenRA:bleed Sep 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Sep 26, 2018

@pchote pchote deleted the pchote:notification-lint branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment