New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TickIdle calls from World.Tick to Actor.Tick #15671

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@reaperrr
Copy link
Contributor

reaperrr commented Oct 1, 2018

  • avoids those extra ActorsHavingTrait look-ups in World.Tick
  • allows caching INotifyIdle in Actor

If the numbers from a customized version of our benchmark mode are to be believed, the average cost of activities+TickIdle combined is measurably lower with this PR (on RA shellmap) compared to bleed.

reaperrr added some commits Oct 1, 2018

Run TickIdle from inside Actor.Tick instead of World.Tick
Avoids calling ActorsWithTrait<INotifyIdle> every tick and allows caching all INotifyIdle traits at creation.
Remove IsIdle check from DrawLineToTarget.OnBecomingIdle
OnBecomingIdle is triggered when IsIdle becomes true, so this check is bogus.

@pchote pchote added this to the Next + 1 milestone Oct 1, 2018

@abcdefg30 abcdefg30 merged commit 3e73357 into OpenRA:bleed Oct 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment