New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy building.Locked and building.BuildComplete from Gate. #15676

Merged
merged 1 commit into from Oct 7, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Oct 3, 2018

Another step towards eliminating these legacy code warts.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 3, 2018

Re (lack of) update rules: we have a few traits left to do, with a lot of that work already sitting open in parallel PRs. Most of the rule changes also span multiple levels of inheritance, so i'm not sure we can even usefully show a list of actors to change. If we don't have any better ideas I think our best option is to make a general note about this on https://github.com/OpenRA/OpenRAModSDK/wiki/Update-notes:-release-20180923-to-next

@@ -34,7 +34,7 @@ public class GateInfo : PausableConditionalTraitInfo, ITemporaryBlockerInfo, IBl
}

public class Gate : PausableConditionalTrait<GateInfo>, ITick, ITemporaryBlocker, IBlocksProjectiles,
INotifyAddedToWorld, INotifyRemovedFromWorld, INotifyBlockingMove, ISync

This comment has been minimized.

@MustaphaTR

MustaphaTR Oct 5, 2018

Member

There is a value with [Sync] (Position), why remove ISync? Tbh this doesn't look related so i guess this was a mistake.

This comment has been minimized.

@abcdefg30

abcdefg30 Oct 5, 2018

Member

ConditionalTrait already implements ISync, so we can remove it here.

This comment has been minimized.

@MustaphaTR

MustaphaTR Oct 5, 2018

Member

Makes sense.

@MustaphaTR
Copy link
Member

MustaphaTR left a comment

Didn't notice any regressions about Gates in TS mod.

@pchote pchote force-pushed the pchote:remove-gate-legacy-building-code branch from 7ee2e87 to 0b41cd9 Oct 6, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 6, 2018

Renamed makeanimation-active to build-incomplete to match #15682.

@abcdefg30 abcdefg30 merged commit 3b16938 into OpenRA:bleed Oct 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 7, 2018

@pchote pchote deleted the pchote:remove-gate-legacy-building-code branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment