Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter default tabs' drop-down heights to align with the RA mod. #15678

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@SoScared
Copy link
Member

SoScared commented Oct 4, 2018

The default values cuts off the ra mod's dropdown options. They don't interfere with other mods cut-off because of their shorter option lists.

lobby1
lobby2

It would be nice to have these values as user defined so modders can polish the initial visible options, e.g. here RA faction drop-down presents the countries and has the random factions are scrollable.

}

public static void ShowPlayerActionDropDown(DropDownButtonWidget dropdown, Session.Slot slot,
Session.Client c, OrderManager orderManager, Widget lobby, Action before, Action after)
Session.Client c, OrderManager orderManager, Widget lobby, Action before, Action after)

This comment has been minimized.

@SoScared

SoScared Oct 4, 2018

Author Member

these space fixes came unexpectedly along for the ride

@SoScared SoScared changed the title Alter default tabs' dropdown hights to allign with the RA mod. Alter default tabs' drop-down heights to align with the RA mod. Oct 4, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 4, 2018

IMO it would make more sense for the dropdown logic to round the dropdown height to the next smallest full-object height. The default height can also move to metrics so each mod can set it individually.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Feb 22, 2019

@pchote would you object to taking this as-is for prep and open an issue for

would make more sense for the dropdown logic to round the dropdown height to the next smallest full-object height

targeting Next+1?

This PR does add some visual polish, so as temporary fix it's fine, I think.
Preliminary 👍 from me.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Feb 22, 2019

No real objection from me, but i'll let you create the issue.

@pchote

pchote approved these changes Feb 22, 2019

@pchote pchote merged commit b480fec into OpenRA:bleed Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.