New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove INotifyBuildComplete from render traits. #15682

Merged
merged 2 commits into from Oct 7, 2018

Conversation

Projects
None yet
2 participants
@pchote
Copy link
Member

pchote commented Oct 6, 2018

This PR removes the hardcoded logic that disables most render traits while WithMakeAnimation is active. The default mod rules are migrated to use conditions, and an update rule is provided to help other mods apply the same fixes.

This gets us most of the way towards completing #7035.

@pchote pchote added this to the Next + 1 milestone Oct 6, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 6, 2018

Once this and our other legacy → condition migration PRs are merged I hope to go through the default mods and disable all building behaviours that don't make sense be active during the make animations: radar, support powers, production, weapons, etc. This will fix #11349 and several other long standing polish issues for good.

@pchote pchote force-pushed the pchote:remove-buildcomplete-render branch from 7c00335 to 9ee6d5b Oct 6, 2018

@pchote pchote force-pushed the pchote:remove-buildcomplete-render branch 2 times, most recently from c8a5fff to 2ed6ad4 Oct 6, 2018

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 7, 2018

Needs a rebase.

@pchote pchote force-pushed the pchote:remove-buildcomplete-render branch from 2ed6ad4 to 6e37cdb Oct 7, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 7, 2018

Rebased.

@pchote pchote removed the PR: Rebase me! label Oct 7, 2018

@abcdefg30 abcdefg30 merged commit e038b86 into OpenRA:bleed Oct 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 7, 2018

@pchote pchote deleted the pchote:remove-buildcomplete-render branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment