New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SpriteEffect, remove limited-use effects #15690

Merged
merged 3 commits into from Dec 4, 2018

Conversation

Projects
None yet
2 participants
@reaperrr
Copy link
Contributor

reaperrr commented Oct 7, 2018

...and unhardcode GainsExperience levelup effect.

Originally started working on this because I stumbled over the latter.

In summary, this PR

  • adds support for dynamically updating position and facing of SpriteEffect while the animation is running
  • uses the above to replace the recently added LaunchEffect as well as CrateEffect
  • unhardcodes (and disables by default) the levelup crate effect spawned by GainsExperience (so mods that aren't based on any official mod can use GainsExperience without a levelup crate effect)

@reaperrr reaperrr force-pushed the reaperrr:upgrade-SpriteEffect branch from adc1be8 to 809511c Oct 7, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Oct 7, 2018

adds support for dynamically updating position and facing of SpriteEffect while the animation is running

This should also bring us a step closer to TS-style smoke particles.

@reaperrr reaperrr force-pushed the reaperrr:upgrade-SpriteEffect branch 2 times, most recently from e9738a0 to 93c42e0 Nov 19, 2018

Updated

@pchote pchote added this to the Next Release milestone Nov 21, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 25, 2018

Needs a rebase.

reaperrr added some commits Oct 7, 2018

Add dynamic position support to SpriteEffect
This was the last missing 'puzzle piece' to replace some remaining spcial-case effects.

@reaperrr reaperrr force-pushed the reaperrr:upgrade-SpriteEffect branch from 93c42e0 to 27cf370 Nov 25, 2018

@reaperrr reaperrr force-pushed the reaperrr:upgrade-SpriteEffect branch from 27cf370 to af9364d Nov 25, 2018

@pchote pchote removed the PR: Rebase me! label Nov 25, 2018

@pchote

pchote approved these changes Dec 4, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 4, 2018

Considering the lack of review bandwidth i'll take this without a second 👍

@pchote pchote merged commit eb86160 into OpenRA:bleed Dec 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment