New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint warnings about not using the being-captured condition #15696

Merged
merged 3 commits into from Oct 15, 2018

Conversation

Projects
None yet
4 participants
@abcdefg30
Copy link
Member

abcdefg30 commented Oct 9, 2018

Fixes an oversight from #15661. The warnings are reported by travis (take https://travis-ci.org/OpenRA/OpenRA/jobs/438730771#L1790 for example).

@@ -63,7 +63,6 @@ HVR:
Mobile:
Speed: 99
Locomotor: hover
RequiresCondition: !empdisable

This comment has been minimized.

@reaperrr

reaperrr Oct 11, 2018

Contributor

Why are you removing this? The hover tank should be just as emp-able and capturable as any other vehicle.

This comment has been minimized.

@pchote

pchote Oct 11, 2018

Member

I suspect this was already inherited from the default template?

This comment has been minimized.

@abcdefg30

abcdefg30 Oct 11, 2018

Member

That is the case.

@pchote

pchote approved these changes Oct 11, 2018

Copy link
Member

pchote left a comment

Not tested, but the lint checks now pass so I don't expect this to be any worse than current bleed.

But lets please at least briefly test all affected actors ingame before merging.

@pchote pchote added the PR: Needs +2 label Oct 11, 2018

@MustaphaTR
Copy link
Member

MustaphaTR left a comment

Tested all the effected units on both mods, it is working as it should.

@abcdefg30 abcdefg30 merged commit cf4dc42 into OpenRA:bleed Oct 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:lintWarnings branch Oct 15, 2018

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment