New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infantry getting stuck in the last attack frame #15701

Merged
merged 1 commit into from Oct 28, 2018

Conversation

Projects
None yet
2 participants
@abcdefg30
Copy link
Member

abcdefg30 commented Oct 12, 2018

Fixes #12375 and #5884 (comment).

Setting the state to Idle was bogus as we were not entering the first else branch in TickIdle (which also lets the standard animation play). Only setting the state to Waiting instead of Idle made the unit pause in between bursts as TickIdle is not called. Consequently we are now letting the standard animation play and enter the Waiting state to go idle at the next opportunity.

@pchote pchote requested a review from reaperrr Oct 12, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Oct 28, 2018

Code changes are quite straightforward and obvious, and works as promised in-game. I think this doesn't need another +1.

@reaperrr reaperrr merged commit 9cbe7bc into OpenRA:bleed Oct 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Oct 28, 2018

@abcdefg30 abcdefg30 deleted the abcdefg30:lastFrame branch Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment