Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove legacy building plumbing #15743
Four years in the making, this PR completes the final push to replace our legacy Building plumbing with conditions. This old code hardcoded assumptions about the classic C&C semantics for building placement / capturing / demolition / etc across many traits, and has been superseded by conditions. The last few places that depend on the old plumbing are ported to conditions, and the legacy code is removed.
I recommend reviewing commit-by-commit.