New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate palette high bits into the low bits #15745

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Projects
None yet
4 participants
@chrisforbes
Copy link
Member

chrisforbes commented Oct 27, 2018

Previously we didn't quite get the full range -- the most intense value we
could produce was 0xfc.

Replicate palette high bits into the low bits
Previously we didn't quite get the full range -- the most intense value we
could produce was 0xfc.

@chrisforbes chrisforbes requested review from pchote and abcdefg30 Oct 27, 2018

@pchote

pchote approved these changes Oct 28, 2018

@pchote pchote added the PR: Needs +2 label Oct 28, 2018

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Oct 28, 2018

This PR operates with the mindset that the game's still limited to VGA palettes. Jasc/GPL/PNG pals already use those bits. This is exactly the ignorance I expected from here though.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 28, 2018

The code already operates on that assumption - see the lines immediately before the additions here.

This is exactly the ignorance I expected from here though.

If you want to participate in this repository then you need to be mindful of the code of conduct. Your behaviour in our IRC channel completely crossed those lines, and continuing to insult us here is unacceptable. Consider this a final warning.

@chrisforbes

This comment has been minimized.

Copy link
Member

chrisforbes commented Oct 29, 2018

This is all 6-to-8 bit conversion path. If we need a no-conversion path, we can add that separately.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 29, 2018

@chrisforbes we already have that path. It doesn't use this code though, obviously.

@abcdefg30 abcdefg30 merged commit d653614 into OpenRA:bleed Nov 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment