New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke WithMakeAnimation condition at the end of the tick. #15748

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Oct 28, 2018

This fixes traits becoming enabled for a tick between the animation completing and the actor being removed from the world.

Testcase: Apply #15045 and #15743 to a test branch, then add RequiresCondition: !build-incomplete to the production traits in either TD or RA. The production is reenabled for a tick between the sell/undeploy animation completing and the actor being removed from the world.

Revoke WithMakeAnimation condition at the end of the tick.
This fixes traits becoming enabled for a tick
between the animation completing and the actor
being removed from the world.

@abcdefg30 abcdefg30 merged commit fc6ada3 into OpenRA:bleed Nov 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Nov 3, 2018

@pchote pchote deleted the pchote:fix-makeanim-revoke-timing branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment