New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert granting condition from HackyAI #15802

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@reaperrr
Copy link
Contributor

reaperrr commented Nov 8, 2018

In favor of using GrantConditionOnBotOwner.
Updated update rule and shipping mods accordingly.

TD and D2k changes were re-applied using the updated update rule to make sure that works as intended. RA and TS were updated manually.

Fixes #15794.

@reaperrr reaperrr added this to the Next Release milestone Nov 8, 2018

@reaperrr reaperrr force-pushed the reaperrr:fix-ai-desync branch from 4b7cdc4 to dfce78c Nov 8, 2018

@TheChosenEvilOne

This comment has been minimized.

Copy link
Contributor

TheChosenEvilOne commented Nov 8, 2018

update Fort Lonestar otherwise LGTM

Testing map: Fort Lonestar
OpenRA.Utility(1,1): Warning: Actor type player grants conditions that are not consumed: enable-rush-ai, enable-normal-ai, enable-turtle-ai, enable-naval-ai
OpenRA.Utility(1,1): Error: Actor type player defines conditions but does not include a ConditionManager

Revert granting condition from HackyAI
In favor of using GrantConditionOnBotOwner.
Updated update rule and shipping mods accordingly.

@reaperrr reaperrr force-pushed the reaperrr:fix-ai-desync branch from dfce78c to a1aa2e5 Nov 8, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Nov 8, 2018

Updated.

@TheChosenEvilOne
Copy link
Contributor

TheChosenEvilOne left a comment

LGTM

@obrakmann
Copy link
Contributor

obrakmann left a comment

👍

@obrakmann obrakmann merged commit 74fa875 into OpenRA:bleed Nov 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment