New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for player trait prereqs in ProximityCapturable #15810

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
2 participants
@obrakmann
Copy link
Contributor

obrakmann commented Nov 9, 2018

ProximityCapturable.ChangeOwner() is called a few times with a PlayerActor as argument, which causes pc to be null here when Player does not have the ProximityCaptor trait. This adds a lint check which will recognize this condition.

@obrakmann obrakmann force-pushed the obrakmann:fix-proxCapturable-NRE branch from 84189f8 to 91eafe3 Nov 9, 2018

@pchote pchote added this to the Next Release milestone Nov 19, 2018

Show resolved Hide resolved mods/cnc/rules/player.yaml Outdated

@obrakmann obrakmann force-pushed the obrakmann:fix-proxCapturable-NRE branch from 91eafe3 to 5acfb84 Nov 21, 2018

@obrakmann obrakmann changed the title Add ProximityCaptor to Player to prevent NRE in ProximityCapturable Check for player trait prereqs in ProximityCapturable Nov 21, 2018

@pchote

pchote approved these changes Nov 21, 2018

@pchote pchote merged commit 310b631 into OpenRA:bleed Nov 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@obrakmann obrakmann deleted the obrakmann:fix-proxCapturable-NRE branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment