New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Turreted PausableConditionalTrait #15811

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
5 participants
@TheChosenEvilOne
Copy link
Contributor

TheChosenEvilOne commented Nov 10, 2018

No description provided.

@TheChosenEvilOne TheChosenEvilOne force-pushed the TheChosenEvilOne:conditional-turreted branch 2 times, most recently from 8c1e204 to a104f3f Nov 10, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Nov 16, 2018

To whoever reviews this next: Don't forget he needs to remove the testcase before we can merge this.

Show resolved Hide resolved OpenRA.Mods.Common/Traits/Turreted.cs Outdated
Show resolved Hide resolved OpenRA.Mods.Common/Traits/Turreted.cs Outdated

@TheChosenEvilOne TheChosenEvilOne force-pushed the TheChosenEvilOne:conditional-turreted branch from a104f3f to fd5fc5c Nov 17, 2018

@TheChosenEvilOne TheChosenEvilOne force-pushed the TheChosenEvilOne:conditional-turreted branch from fd5fc5c to baf90f1 Nov 17, 2018

@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Nov 20, 2018

Alright, this works from a pure technical standpoint. However, I think the in-world logic is a bit weird. If Turreted is disabled, the turret always points in the same compass direction. However, if the turret actually was disabled and didn't work, you'd expect it to always point into the same direction *relative to the chassis". What are your opinions on this?

@obrakmann
Copy link
Contributor

obrakmann left a comment

Works as intended. In IRC we decided to take this with the behaviour implemented as-is and open a ticket on it right after merging.

Please drop the testcase commit

@TheChosenEvilOne TheChosenEvilOne force-pushed the TheChosenEvilOne:conditional-turreted branch from baf90f1 to c09fb22 Nov 21, 2018

@TheChosenEvilOne

This comment has been minimized.

Copy link
Contributor

TheChosenEvilOne commented Nov 21, 2018

testcase commit has been dropped

@reaperrr reaperrr merged commit e01953a into OpenRA:bleed Nov 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Nov 21, 2018

@TheChosenEvilOne TheChosenEvilOne deleted the TheChosenEvilOne:conditional-turreted branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment