New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OnBecomingIdle to trigger idle actions on aircraft #15848

Merged
merged 4 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@reaperrr
Copy link
Contributor

reaperrr commented Nov 23, 2018

Like circling or landing.
Also added IdleTurnSpeed to allow to set a different turn speed for idle circling and in turn removed hardcoded 1/3 turnspeed from HeliFlyCircle.

Split from #15803.

Will get a follow-up later, replacing LandWhenIdle with a more flexible ActionsWhenIdle.

@pchote pchote added this to the Next Release milestone Nov 23, 2018

@TheChosenEvilOne
Copy link
Contributor

TheChosenEvilOne left a comment

LGTM 👍

reaperrr added some commits Nov 24, 2018

Fix empty activity tick when becoming idle
Activities usually don't do much more than cleanup on their last, 'null' tick.
That, combined with queued activities normally only starting to tick on the next tick,
would lead to visible 1-tick 'gaps' between movement activities.
Non-movement activities would suffer from the same problem,
only with different (presumably less noticable) symptoms.

Now we start ticking any activity that was queued from OnBecomingIdle
immediately, to avoid that issue.
Add IdleTurnSpeed to Aircraft
Instead of hardcoding 1/3 of normal TurnSpeed on HeliFlyCircle.
Use INotifyIdle on Aircraft
For now only to trigger landing or circling.

@pchote pchote dismissed stale reviews from TheChosenEvilOne and themself via 62e0f2a Dec 4, 2018

@pchote pchote force-pushed the reaperrr:air-IdleTurnSpeed branch from c2a8d7c to 62e0f2a Dec 4, 2018

@pchote

pchote approved these changes Dec 4, 2018

Copy link
Member

pchote left a comment

Force-pushed with a rebase.

@pchote pchote merged commit 20ba45d into OpenRA:bleed Dec 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment