New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RA mechanic to repair ally-owned husks #15851

Merged
merged 6 commits into from Nov 25, 2018

Conversation

Projects
None yet
5 participants
@pchote
Copy link
Member

pchote commented Nov 24, 2018

Fixes #14019.
Fixes #9960.

Mechanics now show the goldwrench cursor for own- and ally-husks, and restore vehicles to their original owner. Capturing vs enemy-husks has not changed, and continues to use the "enter" cursor. This is close enough to the way engineers handle repair vs capturing that it should hopefully not cause confusion.

@pchote pchote added this to the Next Release milestone Nov 24, 2018

@pchote pchote force-pushed the pchote:mechanic-husk-interaction branch from ff13795 to be7851e Nov 24, 2018

@Smittytron
Copy link
Contributor

Smittytron left a comment

Works as advertised.

I'd say this closes #9960. The building part of that ticket has a duplicate issue (#5691).

@KOYK

This comment has been minimized.

Copy link
Contributor

KOYK commented Nov 25, 2018

@pchote did you add the ability to disable\enable it in the lobby as an option?

@abcdefg30
Copy link
Member

abcdefg30 left a comment

This will effectively revert #13276 (comment).

Line 34 of Infiltrates.cs needs an adjustment as well.

Show resolved Hide resolved OpenRA.Mods.Cnc/Traits/Infiltration/InfiltrateForTransform.cs Outdated
Show resolved Hide resolved OpenRA.Mods.Cnc/Traits/Infiltration/InfiltrateForTransform.cs Outdated
Show resolved Hide resolved OpenRA.Mods.Cnc/Traits/Infiltration/InfiltrateForTransform.cs Outdated
public object Create(ActorInitializer init) { return new InfiltrateForTransform(init, this); }
}

class InfiltrateForTransform : INotifyInfiltrated

This comment has been minimized.

@abcdefg30

abcdefg30 Nov 25, 2018

Member

Can we name this TransformOnInfiltration to stay in line with TransformOnCapture?

This comment has been minimized.

@pchote

pchote Nov 25, 2018

Member

This would make it inconsistent with all the other InfiltrateFor* traits.

Show resolved Hide resolved OpenRA.Mods.Cnc/Traits/Infiltration/Infiltrates.cs Outdated
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 25, 2018

This will effectively revert #13276 (comment).

This was superseded by #14982

@pchote pchote force-pushed the pchote:mechanic-husk-interaction branch from be7851e to 84a8fe6 Nov 25, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 25, 2018

Fixed.

@obrakmann obrakmann merged commit 8a95241 into OpenRA:bleed Nov 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Nov 25, 2018

Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment