New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose common actor Inits in the map editor. #15881

Merged
merged 4 commits into from Dec 8, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Dec 3, 2018

This PR expands on #15551 by adding plumbing for trait-defined actor properties in the editor, and wiring up actor health, facing, turret facing and stance:

screenshot 2018-12-03 at 11 40 05

Fixes #15849.
Fixes #10818.

@pchote pchote added this to the Next Release milestone Dec 3, 2018

@MustaphaTR
Copy link
Member

MustaphaTR left a comment

Works as described. Tho i'm not sure what to think about the order. Seems like they are dependent on Trait orders on yaml, but it would be way better imo for example if facing and turret facing where next to each other.

resim

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 8, 2018

Generally looks good, just two things I'd prefer to see changed/added (if not in this PR, then at least in a follow-up, but before a playtest):

  • The order feels a bit arbitrary, personally I'd prefer Owner -> Stance -> Health -> Facing -> Turret.
  • We currently still don't have any means to change an actor's position once it's been placed, it would be great if we could add that before branching off a playtest (not a blocker for this PR, though).

Adding fixup label for the order changes, feel free to reject it if there are technical reasons why this can't be done easily.

@pchote pchote force-pushed the pchote:editor-properties branch from c50af7f to f4ae87b Dec 8, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 8, 2018

The order feels a bit arbitrary, personally I'd prefer Owner -> Stance -> Health -> Facing -> Turret.

Done, and added plumbing that allows this to be overridden from yaml.

We currently still don't have any means to change an actor's position once it's been placed

The preview rendering assumes that the preview never moves, so this is easier said than done. I don't think this is likely to be fixed anytime soon.

I've also added a new commit that fixes the dialog position overlapping the actor at larger zooms.

@reaperrr reaperrr merged commit ea9f12f into OpenRA:bleed Dec 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment