New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --utility argument to the AppImages. #15894

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Dec 6, 2018

Closes #15521.

Adding to the milestone so that we can start depending on it for the resource center as part of the Mod SDK.

@pchote pchote added this to the Next Release milestone Dec 6, 2018

@fusion809
Copy link
Contributor

fusion809 left a comment

All appears fine. For future reference, I built this PR, applied as a patch to commit 25464 (13f5ef5), and here are the outputs I got from the various AppImages with the --utility argument: https://gist.github.com/fusion809/a12d1f773d30df4c08b2fe60a92737b5. Mentioning this log just in case it proves helpful in the future.

@pchote pchote added the PR: Needs +2 label Dec 8, 2018

@obrakmann
Copy link
Contributor

obrakmann left a comment

One minor oversight, works otherwise, 👍

Show resolved Hide resolved packaging/linux/buildpackage.sh

@pchote pchote dismissed stale reviews from obrakmann and fusion809 via b517c4e Dec 17, 2018

@pchote pchote force-pushed the pchote:appimage-utility branch from 07239bc to b517c4e Dec 17, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 17, 2018

Fixed and rebased.

@obrakmann
Copy link
Contributor

obrakmann left a comment

👍

@obrakmann obrakmann merged commit 9f30e2e into OpenRA:bleed Dec 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment