New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facing support to GravityBomb #15895

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
5 participants
@MustaphaTR
Copy link
Member

MustaphaTR commented Dec 7, 2018

Closes #15808.

For testcase i replaced the RA mod parabombs with medium tanks.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:gravity-bomb-facing branch from 1f52191 to e2acf17 Dec 7, 2018

@TheChosenEvilOne
Copy link
Contributor

TheChosenEvilOne left a comment

LGTM 👍

@MustaphaTR

This comment has been minimized.

Copy link
Member

MustaphaTR commented Dec 24, 2018

Updated.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 24, 2018

LGTM after testcase is removed 👍

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:gravity-bomb-facing branch from 587fa73 to cdbd02c Dec 24, 2018

@MustaphaTR

This comment has been minimized.

Copy link
Member

MustaphaTR commented Dec 24, 2018

Updated.

@TheChosenEvilOne
Copy link
Contributor

TheChosenEvilOne left a comment

well that is simple 👍

@obrakmann obrakmann merged commit a2ac95d into OpenRA:bleed Dec 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Dec 24, 2018

@MustaphaTR MustaphaTR deleted the MustaphaTR:gravity-bomb-facing branch Dec 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment