Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to grant condition multipile times to GrantExternalConditionCrateAction #15899

Merged
merged 1 commit into from Apr 22, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Dec 10, 2018

Closes #15868.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:gecca-amount branch from c05927e to f854dff Jan 2, 2019

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

Updated.

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

Can we get this in so i have a reason to go back and update the SS mod?

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:gecca-amount branch from f854dff to d6dcebd Mar 15, 2019

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

Updated.

@pchote
Copy link
Member

left a comment

One last simplification, then LGTM. I've tested that this, with my suggested change, works correctly ingame.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:gecca-amount branch from d6dcebd to e0a5a83 Mar 31, 2019

@pchote
pchote approved these changes Apr 22, 2019

@pchote pchote added the PR: Needs +2 label Apr 22, 2019

@reaperrr reaperrr merged commit 2bb2d6e into OpenRA:bleed Apr 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:gecca-amount branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.