New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix player score not updating while game info screen is visible #15915

Merged
merged 2 commits into from Dec 23, 2018

Conversation

Projects
None yet
3 participants
@obrakmann
Copy link
Contributor

obrakmann commented Dec 18, 2018

This fixes an inconsistency in the game info screen. The team scores will update dynamically while the screen is visible, but the player scores will not. This fixes this oversight.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 18, 2018

Lets get this in for the playtest.

@pchote pchote added this to the Next Release milestone Dec 18, 2018

@obrakmann obrakmann force-pushed the obrakmann:fix-stats-screen-score-updates branch 2 times, most recently from 683017a to 3029578 Dec 20, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 20, 2018

LGTM otherwise 👍

@obrakmann obrakmann force-pushed the obrakmann:fix-stats-screen-score-updates branch from 3029578 to a17345c Dec 21, 2018

@pchote

pchote approved these changes Dec 21, 2018

@reaperrr reaperrr merged commit 680ffff into OpenRA:bleed Dec 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 23, 2018

@obrakmann obrakmann deleted the obrakmann:fix-stats-screen-score-updates branch Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment