Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interface to prevent actors from being spawned by SpawnMapActors #15929

Merged
merged 1 commit into from Jan 7, 2019

Conversation

@obrakmann
Copy link
Contributor

commented Dec 22, 2018

Requested by IceReaper/KKnD#22, and is a prerequisite for #15774.

@pchote

This comment has been minimized.

Copy link
Member

commented Dec 22, 2018

Looks reasonable to me, but I will wait until I have tested it before giving a formal 👍

Ping @IceReaper for review.

@obrakmann obrakmann force-pushed the obrakmann:ipreventmapspawn branch from 97b66a3 to 0bf964f Dec 24, 2018

@obrakmann obrakmann force-pushed the obrakmann:ipreventmapspawn branch from 0bf964f to e950e57 Dec 26, 2018

@IceReaper
Copy link
Contributor

left a comment

Played around a little bit with that, thats exactly what i need to disable particular actors in combination with bunker disabling :)

@pchote
Copy link
Member

left a comment

Sorry for delaying this so long, was putting off merging this until after approval from @IceReaper and the prep branchoff. I unfortunately spotted one last issue while double checking before merging:

OpenRA.Mods.Common/Traits/World/SpawnMapActors.cs Outdated Show resolved Hide resolved

@pchote pchote force-pushed the obrakmann:ipreventmapspawn branch from e950e57 to 633ae6e Jan 7, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Force pushed a fixup to save you the hassle.

@pchote
pchote approved these changes Jan 7, 2019

@pchote pchote merged commit c2cf8ba into OpenRA:bleed Jan 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@obrakmann obrakmann deleted the obrakmann:ipreventmapspawn branch Jan 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.