New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryRemoteMapDetails sets each maps's status now correctly #15933

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
3 participants
@skruw
Copy link
Contributor

skruw commented Dec 22, 2018

Closes #15913

Maps will not remain in Status Searching, if the search is already over.

This is my first PR. Hope I did everything right :).

@obrakmann
Copy link
Contributor

obrakmann left a comment

Looks ok, but you might want to shorten the title of your commit... 👍

@skruw

This comment has been minimized.

Copy link
Contributor

skruw commented Dec 23, 2018

Hi. Thank you for your response. I really don't know how to do that. Can you help me out here?

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 23, 2018

If you run git commit --amend from a terminal on this branch it should pop up an editor that lets you edit the commit message. https://chris.beams.io/posts/git-commit/#seven-rules is a good reference for commit message best practice, but for this something like "Fix QueryRemoteMapDetails multi-map status updates" would be fine.

You'll then need to force-push the branch using git push origin +fixQueryRemoteMapDetailsStatus. The + symbol before the branch name tells git that you really do want to overwrite the current state of the remote branch, otherwise it would be rejected.

@skruw skruw force-pushed the skruw:fixQueryRemoteMapDetailsStatus branch from a765bf1 to 9168f16 Dec 23, 2018

@skruw

This comment has been minimized.

Copy link
Contributor

skruw commented Dec 23, 2018

Thank you very much. I'll look into your link.

@pchote

pchote approved these changes Dec 24, 2018

Copy link
Member

pchote left a comment

Fix confirmed

@pchote pchote merged commit 7184f5f into OpenRA:bleed Dec 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment