New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change existing husks to neutral when owner loses. #15935

Merged
merged 1 commit into from Dec 23, 2018

Conversation

Projects
None yet
4 participants
@pchote
Copy link
Member

pchote commented Dec 23, 2018

The current behaviour on bleed regarding husks is:

  • Actor dies during normal gameplay → Husk is owned by the original player
  • Actor dies because owner loses → Husks is owned by the Neutral player
  • Actor dies during normal gameplay, and the owner then loses → Husk is owned by the original player

Having different behaviour for husks spawned before and after a player loses is clearly a bug, so the obvious fix here is to change the owner for existing husks to neutral if the owner loses. Remember that husks always show the tooltip and player colors for the original owner, even when owned by the neutral player.

It is important to fix this before the playtest because it leads to a nasty edge case with repairing ally MCV husks:

  • MCV dies during normal gameplay → repaired MCV is restored to the original player
  • MCV dies because owner loses → repaired MCV is restored to the mechanic's owner
  • MCV dies during normal gameplay, and the owner then loses → repaired MCV is restored to the original player, who can then control and deploy it but not build anything because they have the observer interface instead of the sidebar.

@pchote pchote added this to the Next Release milestone Dec 23, 2018

@MustaphaTR
Copy link
Member

MustaphaTR left a comment

👍

@pchote pchote added the PR: Needs +2 label Dec 23, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 23, 2018

What about MCV husks in TD? I assume engineers work a bit differently from mechanics, just making sure.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 23, 2018

TD always spawns husks owned by neutral, so a player losing doesn't affect them.

@obrakmann obrakmann merged commit 3817c7b into OpenRA:bleed Dec 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment