New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BotModule sync check debug setting. #15942

Merged
merged 5 commits into from Dec 26, 2018

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Dec 23, 2018

Fixes #15858.

@pchote pchote added this to the Next Release milestone Dec 23, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 24, 2018

Looks good. We should at least check if the building repair module can be performance-optimized as checking sync around it can lag even fast machines, but that's a separate issue.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 24, 2018

The issue won't be the repair module, but with the sync calculation itself which is relatively expensive.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 24, 2018

I wonder whether it would be smarter to not implement a GUI option for this - we don't want people accidentally enabling this considering the perf overheads.

@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Dec 24, 2018

I wonder whether it would be smarter to not implement a GUI option for this - we don't want people accidentally enabling this considering the perf overheads.

What I'd do is keep all the checkboxes, but hide them all behind a config option that doesn't have one. So for normal users, the whole Debug section on the advanced page wouldn't be visible.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 26, 2018

Done. I also added a checkbox for your strict activity checking (will hopefully remind people that this work is still not complete), and additional description tags for https://github.com/OpenRA/OpenRA/wiki/Settings.

@obrakmann obrakmann removed the PR: Needs +2 label Dec 26, 2018

@obrakmann
Copy link
Contributor

obrakmann left a comment

👍

@reaperrr reaperrr merged commit 2a2ad71 into OpenRA:bleed Dec 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment