New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange default observer hotkeys #15957

Merged
merged 2 commits into from Jan 4, 2019

Conversation

Projects
None yet
6 participants
@dragunoff
Copy link
Contributor

dragunoff commented Dec 27, 2018

  • Move replay speed hotkeys to F9 - F12
  • Set F5 as default for StatisticsGraph

Closes #15956

@teinarss

This comment has been minimized.

Copy link
Contributor

teinarss commented Dec 28, 2018

Could this be done for TD and the other mods as well if it's missing there?

@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Dec 28, 2018

@teinarss These definitions live in common|hotkeys/observer.yaml so they apply to all core mods.

@MustaphaTR

This comment has been minimized.

Copy link
Member

MustaphaTR commented Dec 28, 2018

@teinarss These definitions live in common|hotkeys/observer.yaml so they apply to all core mods.

I don't think this can be said for everything in common, tho in this case it is correct.

@matjaeck
Copy link
Contributor

matjaeck left a comment

Working as advertised in RA, CNC, D2K. Could we add F7 as hotkey for the army value graph after #15767 is merged (in this or a follow-up PR)?

@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Dec 30, 2018

Sure, once that is merged I can rebase and add F7.

@pchote pchote added this to the Next Release milestone Jan 1, 2019

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Jan 1, 2019

@dragunoff Ready for rebase.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 1, 2019

We're going to want this in the playtest to go along with the army graph.

dragunoff added some commits Dec 27, 2018

Rearrange default observer hotkeys
* Move replay speed hotkeys to `F9 - F12`
* Set `F5` as default for `StatisticsGraph`

@dragunoff dragunoff force-pushed the dragunoff:feature/rearrange-observer-hotkeys branch from 790d9c3 to f3910de Jan 2, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Jan 2, 2019

Rebased and updated. I've added the hotkey for the army value panel in a separate commit.

@matjaeck
Copy link
Contributor

matjaeck left a comment

Works and F6 is the correct hotkey, not F7. 👍

@pchote

pchote approved these changes Jan 4, 2019

@pchote pchote merged commit caead31 into OpenRA:bleed Jan 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment