New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate smooth scrolling per-frame instead of per-tick. #15974

Merged
merged 1 commit into from Jan 1, 2019

Conversation

Projects
None yet
6 participants
@pchote
Copy link
Member

pchote commented Dec 31, 2018

This PR changes ScrollPanelWidget to update the smooth scrolling position every frame instead of every tick. This increases the animation smoothness by 2.4x (assuming 60FPS rendering), which dramatically improves the perceived performance.

Testcase: Open the map chooser and scroll using the mousewheel / trackpad gesture.

This is a big polish win, so I'd like to get this into the playtest.

@pchote pchote added this to the Next Release milestone Dec 31, 2018

@Smittytron
Copy link
Contributor

Smittytron left a comment

Yep, certainly looks better.

@pchote pchote added the PR: Needs +2 label Dec 31, 2018

@TheChosenEvilOne
Copy link
Contributor

TheChosenEvilOne left a comment

smooth as butter 👍

@matjaeck
Copy link
Contributor

matjaeck left a comment

Feels good.

@Sininini

This comment has been minimized.

Copy link

Sininini commented Jan 1, 2019

This is excellent! Thank you

@reaperrr reaperrr merged commit d7c54d7 into OpenRA:bleed Jan 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment