New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map editor tiles filters #15976

Merged
merged 2 commits into from Jan 1, 2019

Conversation

Projects
None yet
3 participants
@rob-v
Copy link
Contributor

rob-v commented Dec 31, 2018

Closes #15888

  1. move some common logic to CommonSelectorLogic
  2. add Category multiple selection for tiles like for actors
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 31, 2018

Stylecop reports:

OpenRA.Mods.Common/Widgets/Logic/Editor/TileSelectorLogic.cs(91,8): error CS0219: Warning as Error: The variable `categorySelector' is assigned but its value is never used

@rob-v rob-v force-pushed the rob-v:MapEditorTilesFilters branch 2 times, most recently from 3c34f24 to 494ec78 Dec 31, 2018

@rob-v

This comment has been minimized.

Copy link
Contributor

rob-v commented Dec 31, 2018

Fixed. The update for tile multi selection could be simpler to do and review if preferred without moving common code to new class.

@pchote

pchote approved these changes Dec 31, 2018

@pchote pchote added this to the Next Release milestone Dec 31, 2018

@pchote pchote added the PR: Needs +2 label Dec 31, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 31, 2018

This goes well with the other editor improvements, so lets get this in for the playtest.

@Smittytron
Copy link
Contributor

Smittytron left a comment

Looks good

@pchote pchote merged commit 8c94f26 into OpenRA:bleed Jan 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment