New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around AI targeting issues #15979

Merged
merged 4 commits into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@pchote
Copy link
Member

pchote commented Dec 31, 2018

Fixes #15967 and removes the main culprit behind #3468. This restores some of the AI's former competence - it no longer stalls with idle units being continuously ordered to do things they can't act on.

pchote added some commits Dec 31, 2018

Disable target recalculation for bots.
This fixes bot-controlled units freezing when they
lock on to units that aren't visible.
Increase squad calculation intervals.
These were unnecessarily short, increasing the
AI performance overhead, and making it difficult
for units to escape concave terrain features.

@pchote pchote added this to the Next Release milestone Dec 31, 2018

@Smittytron
Copy link
Contributor

Smittytron left a comment

The improvement is immediately apparent.

The only AI squad I saw get stuck was one that wanted to go attack a naval yard that hadn't been discovered yet. There were still plenty of ground targets for them to search for. 👍 if that's beyond the scope here.

@pchote pchote added the PR: Needs +2 label Dec 31, 2018

@TheChosenEvilOne
Copy link
Contributor

TheChosenEvilOne left a comment

works fine 👍

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Jan 1, 2019

I noticed while spectating an AI match that bots will attack base defenses although the bot has not revealed the defense structure yet. Not sure if that is an issue (or intended?). AI's seem to deal correctly with aircraft now (not hunting them with units that can't attack them / dropping the target when they lose vision).

@matjaeck
Copy link
Contributor

matjaeck left a comment

I spectated/played some (RA) games versus the AI and didn't encounter any issues regarding AI targeting aside from the observation mentioned in the comment above.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 2, 2019

Yes, bots attacking things through the fog is intentional (its actually the whole point of this PR!).

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Jan 2, 2019

Well in this case I can confirm it works :)

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Jan 2, 2019

I'm still seeing actors targeting aircraft way out of range and sight:
stillbuggy

I also saw AI missile subs continue shooting at the position of an already-dead turret (I know this is basically the correct behavior vs frozen actors now, but it's not optimal for bots).

Edit: And yes, I even recompiled once more to make sure I didn't just forget that.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 2, 2019

I only fixed the rush-attack vs aircraft case because that was the most common cause of the bug with basically no tradeoff (why would anyone rush against an aircraft?). If you insist then I can block the other vs-aircraft cases, but this may introduce other regressions.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Jan 3, 2019

but this may introduce other regressions

Nah, let's not risk that.
I guess this is good enough for now.

@reaperrr reaperrr merged commit 5a8f7f1 into OpenRA:bleed Jan 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment