Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add hotkey for removing selected actors from control groups #15990
In this PR:
I'd like to see other people's opinions on this, but IMO we shouldn't add this - I don't think any of the original games had a specific hotkey for this, and the same function can be achieved by adding the unit to a different group.
Every new hotkey type adds an overhead for players to remember, and a maintenance burden / opportunity cost for us (reducing the number of keys available for other things). Also note that ` in particular moves around on various international keyboard layouts, and when paired with Cmd on macOS (all Ctrl shortcuts are remapped to Cmd) it doesn't seem to work.
Most people will have to use both hands to hit these keys. If we look back at the original issue, time and control have been the main factors that motivated the author to ask for this feature. In his opinion, re-assigning the control-group would create a greater "mess" than removing certain units from a control-group. I know that these settings could be changed to a more ergonomic setup by the player, however these defaults alone make me doubt if there is any additional value in this change.
The author raised another point that is more interesting IMO: Removing units from control-groups when they are sent to repair. It is the underlying problem this feature request tries to address. You have to remove those units from a control group, that you want to send to repair. Otherwise any order given to the control-group will "overwrite" the repair order.
IMO, there is no problem with assigning control-groups (which includes the removal of units from control-groups). However - and this would need to be discussed separately - I would support a change that removes units (temporarily?) from control groups, when they are send to repair.
MustaphaTR is right that a unit can only be in one control group. This means that you already have a very fast and more comfortable solution to remove single units from conrol-groups by assigning a "dummy" control-group to them. In the light of this, I don't see additional value in this change that justifies the costs pchote already mentioned.
@pchote Those are all valid points and things that I've been thinking about as well. I agree we need more opinions here. Here's my opinion:
Overhead for players
Any piece of software with a complex UI will probably have a lot of hotkeys (think of photo editing suites, softrawe IDEs, etc.) and novice users will perform most tasks first with the mouse, gradually learning the hotkeys and deciding which ones make sense to their workflow (playstyle).
The need for this hotkey
Perhaps this is not sufficient to justify the existence of such a hotkey. And as mentioned there is a work-around (adding to a dummy group) but to me that feels awkward.
abcdefg30 left a comment
I agree with Mustapha that