Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder stance hotkeys in settings to match command bar #15996

Merged

Conversation

@dragunoff
Copy link
Contributor

commented Jan 4, 2019

This is a minor polishing fix. The hotkey settings for stances were in reverse order to the order seen in-game on the command bar. This made rebinding them more mentally taxing and prone to errors.

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jan 6, 2019

Apparently I read the rebindings in a different order, top left then bottom left, top right, bottom right:
grafik

However, I won't object if others think this is fine.

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2019

Looking at other hotkeys (production slots for example) the order is clearly left-to-right (i.e. top left, top right, bottom left, bottom right).

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2019

Looking at other hotkeys (production slots for example) the order is clearly left-to-right (i.e. top left, top right, bottom left, bottom right).

I don't think this can be said for all items, for example the Record bookmark or Jump to bookmark items are top-to-bottom, whereas the Slot 01 to Slot 24 in the Production Commands section are left-to-right.

I find it more comfortable to read descriptions that are in numerical order (slot#, bookmark#) from top to bottom, like columns and rows (rows may continue in the next column). So I would prefer if we used the top-to-bottom order for other items, too (we could break columns by logical groups, like in the Viewport Commands).

Right now we are just inconsistent with the order of items, both in the context of how it is displayed in-game and by which logic it is ordered in the settings.

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

I'm all for consistency. And the engine is clearly laying them out left-to-right. In the case of Record bookmark and Jump to bookmark: these are corresponding pairs of hotkeys which - when you look at it that way - are also layed out left-to-right. Changing the order to top-to-bottom would require changing how the rendering for the fields works. And that is out of scope here. This PR's only aim is to bring the order in line with the stance bar (Attack Anything, Defend, Return Fire, Hold Fire) :-)

@matjaeck
Copy link
Contributor

left a comment

You're right, it's left-to-right. I apologize for the wasted time - didn't notice. Changes here make sense.

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

No worries :-) It's important to make things clear. The hotkey settings could certainly use some more usability improvements.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

While my brain prefers the same reading order as @abcdefg30's, @dragunoff is right that this is consistent with other categories and that changing the field render order is out of scope here.

@reaperrr reaperrr merged commit 3b62493 into OpenRA:bleed Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dragunoff dragunoff deleted the dragunoff:fix/reorder-stance-hotkeys-in-settings branch May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.