New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid target crash if Leap target dies. #15998

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Jan 4, 2019

Fixes #15993.

@pchote pchote added this to the Next Release milestone Jan 4, 2019

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Jan 4, 2019

Shouldn't this have a target condition setting now to stun targets akin to the capturing issues?

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 4, 2019

No, because Leap explicitly accounts for targets that move - this is where the crash crept in.

@abcdefg30 abcdefg30 merged commit 4d3db0d into OpenRA:bleed Jan 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment